search

aeternity / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
0 stars 1 forks source link

After sending the tip during the League event, the pop up did not disappear #269

Open Liubov-crypto opened 4 years ago

Liubov-crypto commented 4 years ago

After sending the tip, the pop up did not disappear, as usual, but remained. It could be used to enter the conference room again. Steps to reproduce:

  1. Choose user
  2. Click on the icon on avatar/text message
  3. Put the amount and text
  4. Send Tip
  5. Confirm transaction on the pop-up
  6. See the error: pop up doesn't disappear

Знімок екрана 2020-10-23 о 7 13 01 пп

This behaviour is not reproduced in the Jitsi tab only was on League event. I recorded a video: https://youtu.be/Px9-jvVzI64

OS: Mac 10.15.7 Browser: Brave iframe wallet

davidyuk commented 4 years ago

@venimus @shapkarin

Deeplinks are not intended to be used in this way: https://github.com/aeternity/jitsi-meet/blob/85c429d5d2896153150eb6d246db2d3d75641073/react/features/aeternity/components/TipButton.js#L311-L326

Here is an example that should work in all cases: https://github.com/aeternity/jitsi-meet/blob/4add5f98a03e412c54adf182f0991f062d111569/react/features/conference/components/web/Conference.js#L165-L173

I will investigate the possibility of showing deeplink in a popup (I have concerns regarding mobile apps). Currently, you have to close the popup window by yourself and I don't know the way to detect that popup is ready to be closed.