search

aeternity / superhero-ui

Superhero UI
https://superhero.com
ISC License
19 stars 21 forks source link

refactor(TipRecord): use plain link #1138

Closed davidyuk closed 3 years ago

davidyuk commented 3 years ago

Approach from #1129 applied to TipRecord based on #1135

The only significant change is that the preview always points to a link that this preview for instead of a link to tip comments. This looks reasonable and was easier to implement. @onvisions is it acceptable?

@Liubov-crypto ensure that all kinds of tips behave the same as before except for the issue mentioned above.

github-actions[bot] commented 3 years ago

Deployed to feature-tip-plain-link.aggregator.z52da5wt.xyz, bundle report

davidyuk commented 3 years ago

@Liubov-crypto Isn't it a browser's gesture to navigate to the next page?

If the last page If navigated to previous page before
Screenshot 2021-07-13 at 04 45 15 Screenshot 2021-07-13 at 04 44 15
Liubov-crypto commented 3 years ago

Isn't it a browser's gesture to navigate to the next page?

No, I only had one page open. I checked again and noticed that this behavior only applies to posts "Tip Url". зображення_viber_2021-07-13_12-43-55-913 зображення_viber_2021-07-13_12-43-56-234

Idk, maybe my browser is old, but I have updated to V12.10.5-go.

davidyuk commented 3 years ago
  1. I mixed up Mi Browser Pro and UC browser
  2. I have reproduced and fixed a flexbox issue
Before (UC browser) After (UC browser)
Screenshot 2021-07-13 at 21 47 44 Screenshot 2021-07-13 at 21 57 56

Still preview image height is too high, I will check it

davidyuk commented 3 years ago

🎉