search

aeternity / superhero-ui

Superhero UI
https://superhero.com
ISC License
19 stars 21 forks source link

aepps integration #1158

Closed pseudozach closed 2 years ago

pseudozach commented 3 years ago

Hi, this PR is opened as part of aeppstore project per milestone-3 of the grant (https://forum.aeternity.com/t/active-aepp-store-fast-easy-aepp-discovery/9494)

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

pseudozach commented 3 years ago

Hi, can you please review this PR and let me know if it's feasible? Or any issues with it?

kenodressel commented 3 years ago

Are you committed to maintaining this?

ErkanKanden commented 3 years ago

It is mentioned in the original Foundation grant application that @pseudozach will maintain this for one year: https://forum.aeternity.com/t/active-aepp-store-fast-easy-aepp-discovery/9494

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kenodressel commented 3 years ago

thanks :)

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kenodressel commented 3 years ago

any update @pseudozach?

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

pseudozach commented 3 years ago

any update @pseudozach?

hi, I'm blocked waiting for a payment from the foundation. Once that comes through I'll follow up. thanks and sorry for the delay.

pseudozach commented 3 years ago

@kenodressel please take another look. I've added a new commit with requested syntax. I've checked and both ci and test are passing.

kenodressel commented 3 years ago

I don't see any new commits in this PR.

kenodressel commented 3 years ago

I guess part of your problem is that the first PR is not adhering to the conventional commit standard. Please fix this. An example can be found here: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message

pseudozach commented 2 years ago

how about now? is this better?

stale[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kenodressel commented 2 years ago

hm this seems weird, there are now some commits on your branch that should not be there (from Nikita Cedrik).

stale[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.