Minor issue: quotation marks disappear from tip text

[thescientress]

If people want to quote from articles, we add quotes eg. "text." Quotation marks disappear when the tip goes to the feed.

[shapkarin]

@thescientress can you provide an example link?

[shapkarin]

For this tip: https://superhero.com/tip/2334_v1

I originally wrote the post with quotation marks, as in: "I often wish the young entrepreneurs of Silicon Valley who enabled communication at speed had been forced to run a 9/11 scenario with their technologies before they deployed them commercially." I completely agree.

But the quotation marks disappeared (c) Cecille

---

saved to track at issue

[shapkarin]

@davidyuk the formatted text is comes from the API. So I guess it's processed at the server side. Data comes from the endpoint /cache/tip?id=${tip_id}

[davidyuk]

Check https://wallet.superhero.com/retip?id=2334 There are also no quotation marks, but the data retrieved from the smart contract state, not a backend. Probably they are filtered out on the smart contract call.

[shapkarin]

Check https://wallet.superhero.com/retip?id=2334 There are also no quotation marks, but the data retrieved from the smart contract state, not a backend. Probably they are filtered out on the smart contract call.

thanks a lot, I will check the smart contract

[davidyuk]

On the wallet side the quotes are explicitly removed before tip sending in https://github.com/aeternity/superhero-wallet/blob/8bce63c8f0d7affcb9297bf874e1d0846a97bd69/src/popup/router/pages/Tip.vue#L237 https://github.com/aeternity/superhero-wallet/blob/8bce63c8f0d7affcb9297bf874e1d0846a97bd69/src/popup/utils/helper.js#L219-L220

Git blame doesn't say anything meaningful 🤷‍♀️: https://github.com/aeternity/superhero-wallet/commit/8d3766b85932b69b7460349340bd79ce6a1fe112

[shapkarin]

On the wallet side the quotes are explicitly removed before tip sending in https://github.com/aeternity/superhero-wallet/blob/8bce63c8f0d7affcb9297bf874e1d0846a97bd69/src/popup/router/pages/Tip.vue#L237 https://github.com/aeternity/superhero-wallet/blob/8bce63c8f0d7affcb9297bf874e1d0846a97bd69/src/popup/utils/helper.js#L219-L220

Git blame doesn't say anything meaningful 🤷‍♀️: aeternity/superhero-wallet@8d3766b

thanks, that's the reason