search

aetherknight / recursive-open-struct

OpenStruct subclass that returns nested hash attributes as RecursiveOpenStructs
Other
276 stars 54 forks source link

Fixes bug #46. recurse_over_arrays now preserves array #47

Closed PedroSena closed 7 years ago

PedroSena commented 8 years ago

I changed the way recurse_over_array works to reuse the existing array instead of returning a new array(that was happening when using map).

That way we can rely on @table w/o problems. The only side effect of that is that ros.to_h was showing RecursiveOpenStruct object within the arrays, this was fixed inside deep_dup

bithavoc commented 7 years ago

is there any plan to integrate this @aetherknight ?

aetherknight commented 7 years ago

Apologies for the slowness on this, but I'm not working with Ruby much anymore on a daily basis, so I have been slow about reviewing PRs and bugs.

aetherknight commented 7 years ago

The PR looks good. I will get it merged and try to release it over the weekend. Please comment on this again on Monday if I haven't released an update yet.

bithavoc commented 7 years ago

@aetherknight friendly reminder 😃

aetherknight commented 7 years ago

Thanks! It should be merged and deployed to rubygems now in version 1.0.2.