search

aetheryna / google-scraper-ruby

0 stars 0 forks source link

[B003] As a User, I can upload a CSV #34

Closed aetheryna closed 1 year ago

aetheryna commented 2 years ago

What happened 👀

Created the upload CSV feature 👷🏾. This PR will contain the keywords model and a new migration for the keywords. Just the necessary bits so this feature is workable on. Wrote the relevant tests needed as well 😎

✅ Upload CSV feature ✅ Created Keywords form object ✅ Keywords model ✅ Migration for Keywords ✅ Validator for Keywords form

Insight 📝

Created the form object design pattern following this article. Learned a bit about POROs while working on this as well. As of now the keywords form will accept only CSVs containing words from 1 - 1000. Anything above or lower than this value will be rejected by the application using a Flash message that will appear on the top of the screen (on this PR, will change whilst working on #5)

Proof Of Work 📹

Screen Shot 2022-09-26 at 3 08 21 PM Screen Shot 2022-09-26 at 3 08 36 PM Screen Shot 2022-09-26 at 3 11 19 PM

(Failure on the UI is being handled by the form itself, if the user some how manages to upload a file using the GUI an error will follow )

github-actions[bot] commented 2 years ago

Code coverage is now at 0.00% (0/147 lines)

Generated by :no_entry_sign: Danger