aeventyr / LR2GAS_pub

A re-written version of LR2GAS based on mat's GAS plugin
6 stars 0 forks source link

gauge.cpp tTotal bug (54 Line) #3

Open PARK-SU opened 3 months ago

PARK-SU commented 3 months ago

I would like to report an issue with tTotal. I played a song with a #TOTAL value of 100, but the actual gauge reduction in LR2 is different. If you try playing ★4 Librete, you will clearly notice the difference.

Based on reverse engineering of LR2, I was advised that the actual reduction differs from the current formula. I am attaching the revised formula for your reference.

double tTotal = (bmsTotal >= 240) ? 1 : (bmsTotal < 112) ? 10 : 10 / (((int)((bmsTotal - 112) / 16)) + 2);

Please note that I am not familiar with C++, so I am unsure if the syntax is correct. However, I have been informed that this formula matches the gauge reduction in LR2.

GOMazk commented 2 weeks ago

double tTotal = (bmsTotal<96) ? 10.0 : 10.0 / (double)(bmsTotal/16 - 5 ) ; would be better because we have to calculate 10 / 3 = 3.333, not 3.

LR2GAS2.zip I made a binary patch to solve this problem. Try this until the author handles this issue.