Python 3 tweaks - Githubissues

aeverall / seestar

Creates a selection function given age, metallicity and mass for stellar surveys.

GNU General Public License v3.0

5 stars 2 forks source link

Python 3 tweaks #7

Open Russell-Jones-OxPhys opened 5 years ago

Russell-Jones-OxPhys commented 5 years ago

Apply PEP 3113-- removal of parameter tuple unpacking, i.e. def fn(x, (y, z)) is not allowed in Python 3

~/27ve2/src/seestar$ egrep -ril 'def .*\(.*\('| xargs vim ; reset
/def .*(.*(

Similar for lambdas lambda (x, y) -> lambda x, y

Tabs vs ' '*4 \t -> ' ' (PEP 8)

Russell-Jones-OxPhys commented 5 years ago

I meant to apply these changes and send a PR, but it seems more useful to just note that the changes are needed-- sorry if you've already done these.

aeverall commented 5 years ago

Sorry, I should have responded to this ages ago. Python 3 compatibility is currently not a priority hence why I haven't sorted this. Since it doesn't change the functionality for Python 2 at all, I'll change this in the next set of commits anyway. Thanks for the pointer!