aevyrie / big_space

Floating origin plugin for spaces larger than the universe
Apache License 2.0
168 stars 22 forks source link

Making `FloatingOriginSettings::new` public? #2

Closed tpolakovic closed 1 year ago

tpolakovic commented 1 year ago

The constructor for the settings is not pub, which makes it impossible to make a custom plugin with systems running in a different schedule. If it were to be made public, it will be possible to essentially copy-paste the plugin code with some minor tweaks to run the systems in different schedules (e.g. the fixed time step schedule).

aevyrie commented 1 year ago

This has been resolved. It was made private to prevent users accessing the resource and mutating the settings, as this is not valid. I've added a doc comment, and kept the fields are still private. I'm hoping this is enough to prevent misuse while still allowing for your use case.