search

aewallin / opencamlib

open source computer aided manufacturing algorithms library
http://www.anderswallin.net/CAM
GNU Lesser General Public License v2.1
408 stars 137 forks source link

Adding basic tests to CI, remove outdated examples, improve windows support #132

Closed vespakoen closed 2 years ago

vespakoen commented 2 years ago

Try running ocl libraries in CI

aewallin commented 2 years ago

Would it make sense to split different platforms and bindings into separate workflows? Now with everything together any small error somewhere results in a failed workflow, without a clue of where things go wrong?

Latest ubuntu LTS 22.04 could be included.

Maybe workflows something like:

vespakoen commented 2 years ago

Any error somewhere will make that "job" go red, and will make the "check" fail. I think this is what we want, because in general, opencamlib should compile & run fine on all platforms and variants.

By looking at which job(s) fail, you should be able to pin down the problem(atic platform & binding) pretty easily, so I don't see the problem with the current setup, but it could very well be that I misunderstand your question / problem ;)

I'll change the ubuntu image to 22.04, thanks for the heads up!

I think we can split up the CI using workflows, I am just not sure what the benefits are? From my memory, it is also harder to make some thing run when other workflows ran successfully, vs other jobs, but I just looked that up and it at least seems to be possible now: https://stackoverflow.com/questions/58457140/dependencies-between-workflows-on-github-actions

vespakoen commented 2 years ago

In any case, the CI is basically just calling out some shell scripts and can easily be re-organised, I just think I don't really understand the benefit of splitting it up into workflows like that (yet).