boost/python included despite BUILD_PYTHON_MODULE=OFF

aewallin / openvoronoi

2D voronoi diagram for point and line-segment sites using incremental topology-oriented algorithm. C++ with python bindings. Licensed under LGPL2.1.

http://www.anderswallin.net/cam/

GNU Lesser General Public License v2.1

198 stars 68 forks source link

boost/python included despite BUILD_PYTHON_MODULE=OFF #22

Closed gavanderhoorn closed 9 years ago

gavanderhoorn commented 9 years ago

As per subject.

All of the Boost Python related bits of CMakeLists.txt are skipped when BUILD_PYTHON_MODULE is set to OFF, but offset_sorter.hpp seems to unconditionally include boost/python.hpp (see here).

Later on, there is another issue with boost::python::list offset_list_py().

Making the #include and function definition conditional on BUILD_PYTHON_LIB seems to fix this, but I'm unsure as to the consequences of just disabling things.

gavanderhoorn commented 9 years ago

island_sorter.hpp also unconditionally includes boost/python.hpp.