Closed SiQube closed 1 year ago
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
66278f4
) 100.00% compared to head (809f21d
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I additionally removed mandatory checks for 3.7,
I think the walrus operator make the code less readable but was required for pylint. @dkrako please carefully check if you think we should either disable the walrus, or if it is readable enough.
see here
for the commit in question
One more thing which I am unsure of: do we still need from __future__ import annotations
everywhere?
We have this special pre-commit hook to add it everywhere:
I'm not sure if this was due to python3.7 issues or if thisissue will remain with python3.8?
One more thing which I am unsure of: do we still need
from __future__ import annotations
everywhere?We have this special pre-commit hook to add it everywhere:
I'm not sure if this was due to python3.7 issues or if thisissue will remain with python3.8?
This will remain since there are changes from 3.8 => 3.9 and so on, e.g. here are some 3.12 typing changes. so I'd keep it!
Thanks a lot for all the work!
resolves #457