aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

chore: Migrate typing to matplotlib v3.8.0 #563

Closed SiQube closed 9 months ago

SiQube commented 9 months ago

there are still a couple of TODOs, see https://github.com/pydata/xarray/pull/8030, but we can upgrade to matplotlib==3.8.0.

I'll leave it up to my fellow code owners @dkrako and @prassepaul to decide which way to merge. either this one or #561. this PR would resolve #562

codecov[bot] commented 9 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5e0959f) 100.00% compared to head (077dffb) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #563 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 50 50 Lines 2200 2208 +8 Branches 543 545 +2 ========================================= + Hits 2200 2208 +8 ``` | [Files Changed](https://app.codecov.io/gh/aeye-lab/pymovements/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab) | Coverage Δ | | |---|---|---| | [src/pymovements/plotting/main\_sequence\_plot.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL3Bsb3R0aW5nL21haW5fc2VxdWVuY2VfcGxvdC5weQ==) | `100.00% <100.00%> (ø)` | | | [src/pymovements/plotting/traceplot.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL3Bsb3R0aW5nL3RyYWNlcGxvdC5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SiQube commented 9 months ago

would resolve #562