aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

mypy runs in both pre-commit ci and github actions #573

Closed SiQube closed 9 months ago

SiQube commented 9 months ago

we check mypy with both github actions and pre-commit-ci. maybe we can discuss dropping one (my vote is for github actions).

dkrako commented 9 months ago

my certain vote is to remove both flake8, mypy and pylint completely from pre-commit-ci

dkrako commented 9 months ago

actually I would even opt for removing mypy and pylint from pre-commit completely. they are much too slow, commit times of above 5seconds are totally unacceptable for me and thus pre-commit is currently not very usable as an installed git hook (otherwise one have to type --no-verify everytime on commit). flake8 can stay as it's fast enough.

but maybe there's a way to run these only on pull requests and not for commits.

SiQube commented 9 months ago

you can uninstall pre-commit locally, there is no need to have it installed locally

dkrako commented 9 months ago

I have changed my mind, see #587