dkrako commented 9 months ago

Description

As discussed in today's meeting, #517 probably comes from lots of na-rows in the beginning of a file and faulty inferrence of the column datatype.

Hopefully fixes issue #517

Implemented changes

[x] Specify column dtypes in all public datasets

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

No additional tests written.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (78b649c) 100.00% compared to head (500dfe4) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #593 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 52 52 Lines 2331 2337 +6 Branches 581 582 +1 ========================================= + Hits 2331 2337 +6 ``` | [Files](https://app.codecov.io/gh/aeye-lab/pymovements/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab) | Coverage Δ | | |---|---|---| | [src/pymovements/datasets/gazebase.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2RhdGFzZXRzL2dhemViYXNlLnB5) | `100.00% <100.00%> (ø)` | | | [src/pymovements/datasets/gazebasevr.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2RhdGFzZXRzL2dhemViYXNldnIucHk=) | `100.00% <100.00%> (ø)` | | | [src/pymovements/datasets/hbn.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2RhdGFzZXRzL2hibi5weQ==) | `100.00% <ø> (ø)` | | | [src/pymovements/datasets/judo1000.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2RhdGFzZXRzL2p1ZG8xMDAwLnB5) | `100.00% <100.00%> (ø)` | | | [src/pymovements/datasets/sb\_sat.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2RhdGFzZXRzL3NiX3NhdC5weQ==) | `100.00% <ø> (ø)` | | | [src/pymovements/datasets/toy\_dataset.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2RhdGFzZXRzL3RveV9kYXRhc2V0LnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkrako commented 9 months ago

591 has shown that this PR effectively resolves #517

dkrako commented 8 months ago

@prassepaul @SiQube this is ready for review and resolves the bug in #517

aeye-lab / pymovements

fix: Specify column dtypes in dataset definitions #593