search

aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

ci: test for minimum version of dependencies #599

Closed dkrako closed 8 months ago

dkrako commented 9 months ago

currently we do not test our minimum versions of dependencies. this lead to errors in the past, where users had old openssl packages installed.

this pr adds a test for our minimum supported versions.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (6bf5177) 100.00% compared to head (ce3e256) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #599 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 52 52 Lines 2337 2337 Branches 582 582 ========================================= Hits 2337 2337 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkrako commented 8 months ago

took a a lot of binary search iterations until I identified all minimum dependencies, but this should be it.

I added the explicit pyopenssl dependency (used by urllib), as there were at least two laptops during my tutorial in kaunas that had very outdated pyopenssl versions and therefore couldn't download any dataset.

fixing the minimum version should resolve this problem from now on