search

aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

fix: correct hash in sb-sat definition #606

Closed prassepaul closed 8 months ago

prassepaul commented 8 months ago

Description

Fixes a bug within the sbsat dataset. Changed the download path and the hash.

Type of change

codecov[bot] commented 8 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (a58f779) 100.00% compared to head (a82b0ca) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #606 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 52 52 Lines 2337 2337 Branches 582 582 ========================================= Hits 2337 2337 ``` | [Files](https://app.codecov.io/gh/aeye-lab/pymovements/pull/606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab) | Coverage Δ | | |---|---|---| | [src/pymovements/datasets/sb\_sat.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2RhdGFzZXRzL3NiX3NhdC5weQ==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkrako commented 8 months ago

can you run tox -e integration once and post the output?

prassepaul commented 8 months ago

can you run tox -e integration once and post the output?

tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[GazeOnFaces] PASSED [ 12%] tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[GazeBase] PASSED [ 25%] tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[GazeBaseVR] PASSED [ 37%] tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[HBN] PASSED [ 50%] tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[JuDo1000] PASSED [ 62%] tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[SBSAT] PASSED [ 75%] tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[ToyDataset] PASSED [ 87%] tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[ToyDatasetEyeLink] PASSED [100%]

prassepaul commented 8 months ago

integration test done

dkrako commented 8 months ago

You are dragging a whole rat tail of completely unrelated commits with you.

Please branch out from main the next time you are creating a PR.

I have added an example how to use git alias to shorten this: #608