search

aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

chore: migrate to polars v0.19.12 #618

Closed SiQube closed 8 months ago

SiQube commented 8 months ago

recent update of polars added deprecations to both prefix and shift, which are fixed here. additionally, shift is not working with np.int{32,64} -- return type of np.ceil -- hence the change from .astype(int) to int().

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c94a340) 100.00% compared to head (9bcde3e) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #618 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 52 52 Lines 2349 2349 Branches 588 588 ========================================= Hits 2349 2349 ``` | [Files](https://app.codecov.io/gh/aeye-lab/pymovements/pull/618?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab) | Coverage Δ | | |---|---|---| | [src/pymovements/gaze/integration.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/618?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2dhemUvaW50ZWdyYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [src/pymovements/gaze/transforms.py](https://app.codecov.io/gh/aeye-lab/pymovements/pull/618?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aeye-lab#diff-c3JjL3B5bW92ZW1lbnRzL2dhemUvdHJhbnNmb3Jtcy5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SiQube commented 8 months ago

I've bumped the minimum requirement for polars to prevent a depreciation that will come (soon)

SiQube commented 8 months ago

on top docs had a warning that needed attending, namely 'navigation_with_keys' which I set to the recommended False.

see here:

WARNING: The default value for `navigation_with_keys` will change to `False` in the next release.
If you wish to preserve the old behavior for your site, set `navigation_with_keys=True` in the `html_theme_options` dict in your `conf.py` file.
Be aware that `navigation_with_keys = True` has negative accessibility implications:https://github.com/pydata/pydata-sphinx-theme/issues/1492
SiQube commented 8 months ago

this patch should fix our persisting problem in all other PRs