aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

feat: add PoTeC dataset #636

Closed prassepaul closed 6 months ago

prassepaul commented 7 months ago

Description

This PR adds the PoTeC dataset to pymovements.

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c052e2) 100.00% compared to head (8716001) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #636 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 53 54 +1 Lines 2388 2411 +23 Branches 599 605 +6 ========================================= + Hits 2388 2411 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

prassepaul commented 6 months ago

Somehow the dataset ist not part of DatasetLibrary and I don't get why.

You can run a single test case like this:

pytest tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[PoTeC]

To perform the pytest, you need to install pymovements from path....

output: (tf) prasse@ift-dgx:~/work/Projekte/AEye/pymovements$ pytest tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[PoTeC] ==================================================================================================================================================== test session starts ==================================================================================================================================================== platform linux -- Python 3.9.16, pytest-7.4.3, pluggy-1.3.0 rootdir: /home/prasse/work/Projekte/AEye/pymovements configfile: pyproject.toml plugins: anyio-4.0.0 collected 1 item

tests/integration/public_dataset_processing_test.py . [100%]

=============================================================================================================================================== 1 passed in 460.49s (0:07:40) ===============================================================================================================================================

dkrako commented 6 months ago

To perform the pytest, you need to install pymovements from path....

Ah now I get it, I was always running with my default local environment and just could not understand what was happening

that's what you get from not using tox :D