aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

feat: timestamp unit specification #643

Closed jakobchwastek closed 3 months ago

jakobchwastek commented 6 months ago

Description

Fixes issue #626

Implemented changes

A time_unit specification is mandatory when a time_column is included in the data. To ensure compatibility with certain event detection methods (e.g. idt) I choosed to cast time values to integer after conversion to millis when possible. For example, float timestamps in seconds with millisecond precision (e.g., [0.001, 0.002]) are converted to integer milliseconds ([1, 2]).

Type of change

How Has This Been Tested?

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (6a3af88) to head (09f4a20).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #643 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 57 57 Lines 2669 2696 +27 Branches 688 695 +7 ========================================= + Hits 2669 2696 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.