feat: trialize gaze.detect() - Githubissues

aeye-lab / pymovements

A python package for processing eye movement data

https://pymovements.readthedocs.io

MIT License

57 stars 11 forks source link

feat: trialize gaze.detect() #655

Closed dkrako closed 5 months ago

dkrako commented 5 months ago

Description

With this PR event detection is finally grouped by trials.

Fixes last task in issue #382

please review/merge this issue before: #671

Implemented changes

[x] pass signals and events grouped by trials

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[x] added test cases with trial columns for each event detection method
[x] added test cases for fill to ensure that passed events are grouped accordingly

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c9ff834) 100.00% compared to head (699ac4e) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #655 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 54 54 Lines 2386 2423 +37 Branches 597 614 +17 ========================================= + Hits 2386 2423 +37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.