search

aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

build: add typing_extensions to be able to install pymovements from source #682

Closed SiQube closed 4 months ago

SiQube commented 4 months ago

resolves #679

SiQube commented 4 months ago

I also added trailing comma to the dependencies s.t. we get one line changes for one line changes instead of two lines

SiQube commented 4 months ago

and pre-commit removed them 😸

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (273b7ae) to head (5daa7ab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #682 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 55 55 Lines 2463 2463 Branches 621 621 ========================================= Hits 2463 2463 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkrako commented 4 months ago

All in all this is a strange issue. The dependency was removed here: https://github.com/aeye-lab/pymovements/pull/460/files.

We must have thought that typing_extensions is not needed for python versions >=3.9 ?

Anyway, good that this is resolved