aeye-lab / pymovements

A python package for processing eye movement data
https://pymovements.readthedocs.io
MIT License
57 stars 11 forks source link

fix: operator precedence when building group_filter_expression #734

Closed saeub closed 1 week ago

saeub commented 3 weeks ago

Description

If there are multiple trial columns, the group_filter_expression in GazeDataFrame.detect() is built incorrectly, leading to polars.exceptions.InvalidOperationError: bitand operation not supported for dtype str. This is because the & operator has precedence over ==.

Implemented changes

Type of change

How Has This Been Tested?

Checklist:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (fa4e4db) to head (5d9d45b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #734 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 60 60 Lines 2763 2763 Branches 715 715 ========================================= Hits 2763 2763 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.