search

aezarebski / timtam2

This repository is an implementation of the TimTam likelihood as a BEAST2 package.
https://aezarebski.github.io/timtam/
MIT License
3 stars 0 forks source link

There should be a check that the parameter dimensions are correct #41

Closed aezarebski closed 2 years ago

aezarebski commented 2 years ago

As of v0.2.1 the you can provide a change point for the birth rate and a birth rate of dimension one and it will still run. Usually, there should be a birth rate of dimension two in this case, or in general one more than the number of change points. If this situation arises, the program should exit with a suitable error message indicating the problem.

aezarebski commented 2 years ago

Another thing that might help with this is to include dimension="1" in the BEAUti template so that this is explicit and is easier for people to spot.

aezarebski commented 2 years ago

This has been fixed on the dev branch.