search

aezarebski / timtam2

This repository is an implementation of the TimTam likelihood as a BEAST2 package.
https://aezarebski.github.io/timtam/
MIT License
3 stars 0 forks source link

`IntervalTerminator` is too eager to throw an exception #57

Closed aezarebski closed 1 year ago

aezarebski commented 1 year ago

Description

Instances of IntervalTerminator throw a runtime exception when constructing a parameter with zero probability. Instead it should not throw an exception, but indicate the likelihood of these parameters are zero.

Files involved

To reproduce

Instantiate an interval terminator with a negative count.

Tasks

  1. Fix the interval terminator class so that it does not throw an exception so readily.
  2. Include a check in the likelihood calculation for implausible counts so a negative infinity can be returned for the log-likelihood.
  3. Update the Timtam package version and release it to GitHub.
aezarebski commented 1 year ago

This is being worked on in the interval-terminator-bug-fix branch

aezarebski commented 1 year ago

fixed on 0.4.1