search

afadil / wealthfolio

A Beautiful Private and Secure Desktop Investment Tracking Application
https://wealthfolio.app
GNU Affero General Public License v3.0
4.3k stars 212 forks source link

Instead of using Pnpm , use bun js #99

Open SerJaimeLannister opened 1 month ago

SerJaimeLannister commented 1 month ago

So I had downloaded wealthfolio and ran it using bun install instead of the usual pnpm install and it seems that this worked first try

https://bun.sh/ is said to be faster so it might help and this has much more than just being a faster downloader as compared to pnpm

this has its own features which are faster than node alternatives and thus bun deserves to be a right candidate for such project.

colemvnio commented 4 weeks ago

Bun is marketed as being faster, but it is not mature enough to be used in a production environment without significant risks all while lacking the support/ecosystem that will match the ambitions of this project.

SerJaimeLannister commented 4 weeks ago

Bun is marketed as being faster, but it is not mature enough to be used in a production environment without significant risks all while lacking the support/ecosystem that will match the ambitions of this project.

* Pet projects: Experimental, Playgrounds

* Production: Maturity, Stability

Hey I am interested in hearing why you think so. Bun is basically 1:1 replica of node , I think bun supports react really well (I am not exactly sure , I am a svelte dev but its really really good at svelte)

You can look at bun js discord server , but I do believe that bun is more performant than node and I don't think there has nothing to lose in using bun instead of node

colemvnio commented 4 weeks ago

It is different, and being privately backed has implications for open source projects.

Bun is not mature, and hasn’t proven itself yet to consider refactoring applications for the sake of discords or reddit threads praising it.

Before transitioning, bottlenecks should be thoroughly identified, then introducing resolutions can be thought through.

See: https://bun.sh/docs/runtime/nodejs-apis

On Tue, Oct 8, 2024 at 12:25 SerJaimeLannister @.***> wrote:

Bun is marketed as being faster, but it is not mature enough to be used in a production environment without significant risks all while lacking the support/ecosystem that will match the ambitions of this project.

  • Pet projects: Experimental, Playgrounds

  • Production: Maturity, Stability

Hey I am interested in hearing why you think so. Bun is basically 1:1 replica of node , I think bun supports react really well (I am not exactly sure , I am a svelte dev but its really really good at svelte)

You can look at bun js discord server , but I do believe that bun is more performant than node and I don't think there has nothing to lose in using bun instead of node

— Reply to this email directly, view it on GitHub https://github.com/afadil/wealthfolio/issues/99#issuecomment-2400322031, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXLMHRRDSQ4H6WA3JP5GETLZ2QBOHAVCNFSM6AAAAABOBI4ET6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGMZDEMBTGE . You are receiving this because you commented.Message ID: @.***>

SerJaimeLannister commented 4 weeks ago

Most of the things are implemented really nicely and I don't understand what you mean by corporate backing considering how bun is licensed in MIT license

Bun has released its 1.0 so I do believe that its mature enough to be used in such things

I don't understand if you just hate bun so much or you love node or the fact that you are resisting change but either way , I hope you understand that you need to provide more than repeating that its not mature.

Bun has native sqllite support as well which I have tried and I haven't found much bugs other than a singular case where I had to change the namespace from capital to small IIRC

I have tried bun from 8 months and it seems interesting

though deno 2 has also shipped but I think bun is way faster than deno since deno2 wasn't focused on speed but rather interoperability

colemvnio commented 3 weeks ago

Most of the things are implemented really nicely and I don't understand what you mean by corporate backing considering how bun is licensed in MIT license

Bun has released its 1.0 so I do believe that its mature enough to be used in such things

I don't understand if you just hate bun so much or you love node or the fact that you are resisting change but either way , I hope you understand that you need to provide more than repeating that its not mature.

Bun has native sqllite support as well which I have tried and I haven't found much bugs other than a singular case where I had to change the namespace from capital to small IIRC

I have tried bun from 8 months and it seems interesting

though deno 2 has also shipped but I think bun is way faster than deno since deno2 wasn't focused on speed but rather interoperability

I thought referencing the things that aren't compatible in Bun, from Node was sufficient. The resource itself demonstrates that is not a drop-in replacement, and even if it released a 1.0, it should've stayed in 0.x, unlike Deno for example that is a lot more stable and mature, especially with the 2.0 release (what a timing lollll!).

I believe we/main contributor should first identify performance bottlenecks, roadmap desires, and then look into technologies that can help accomplish that. As of writing, I don't see a need to refactor this for Bun, Deno, Hono or any new flavor of the month. I think it would sidetrack the growth of this project, and doesn't (from my pov) support any objectives.

I think we should focus more on delivering or supporting the main contributor in features, bug fixes, rather than entertaining changes in frameworks.