Feedback - Githubissues

afarnha42 / GDMA-2567-Exercise-1

0 stars 0 forks source link

Feedback #3

Open Enspired opened 4 years ago

Enspired commented 4 years ago

Cleanliness

[ ] - Extra elements line 79, 103, 125 can be removed
[ ] - Line 108 can be under components > layout
[ ] - Reduce repeating styles
[ ] - CSS 246-end of components doesn’t appear to be grouped or categorized in any way
[ ] - Line 360, 364 should be under components > typography
[ ] - Line 380 should be under elements
[ ] - Utilize shorthand properties: border

Functionality

[ ] - Buttons and links in the footer need hover states
[ ] - Third party links should open in a new tab (address)
[ ] - Social icons are not linked

Responsiveness

[ ] Missing row and col- class on line 57
[ ] - Missing col- class line 153, 216
[ ] - Incorrect col- size line 161
[ ] - Font sizes should be defined in REMs not points

Semantics

[ ] - Lines 77, 101, 124 should be semantic elements
[ ] - Utilize contextual ID values
[ ] - Incorrect semantic element line 220, 230, 241
[ ] - Missing text for screen readers for social icons
[ ] - Missing wrapper line 297