Closed damacus closed 6 years ago
Hi!
What're the chances of this getting merged in soon?
@damacus sorry, I had seen this for a while. Thanks for removing all the unnecessary stuff, mostly autogenerated.
I only have one doubt, regarding the Vagrantfile. I use it as a development environment. I don't know if it is a common/good practice, but it allows me to run and re-run the recipe in a clean environment whenever I need to. Do you know another way to use the recipe while you are developing?
I'll be watching this repo from now on.
usually the "standard" way to do this is with test kitchen and chefdk, which under the hood generates a Vagrantfile (or another cloud platform should someone configure that)
For example the HAProxy .kitchen.dokken.yml file configures the dokken provider so that we can run it in Travis easily.
https://github.com/sous-chefs/haproxy/blob/master/.kitchen.dokken.yml
Hope that helps! Dan
On Thu, 25 Jan 2018 at 19:08 Álvaro Faúndez notifications@github.com wrote:
@damacus https://github.com/damacus sorry, I had seen this for a while. Thanks for removing all the unnecessary stuff, mostly autogenerated.
I only have one doubt, regarding the Vagrantfile. I use it as a development environment. I don't know if it is a common/good practice, but it allows me to run and re-run the recipe in a clean enviroment whenever I need to. Do you know another way to use the recipe while you are developing?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/afaundez/nodenv-cookbook/pull/1#issuecomment-360567811, or mute the thread https://github.com/notifications/unsubscribe-auth/AACfUk3EG7rdbAO03rnrbHWgXW7sTc0iks5tONEcgaJpZM4RWlAn .
Fix template to look at the nodenv cookbook rather than the wrapper cookbook (default)
Add a test cookbook with inspec tests
Remove Vagrantfile we no longer require
Remove default delivery and add the community cookbook toml
Remove git_url we're no longer using
Remove default attributes.
Remove the default recipe as we're a library cookbook and we now have a test cookbook
Add root_path helper as we keep trying to find the root path for commands
Grab the rbenv_script and make a nodenv_command resource so we can get the global version easily.
Add inspec tests for global version setting