search

afaundez / nodenv-cookbook

Nodenv Chef Cookbook.
https://supermarket.chef.io/cookbooks/nodenv
MIT License
1 stars 4 forks source link

nodenv codebase not updating after first run when revision is HEAD or a branch #20

Open HP41 opened 2 years ago

HP41 commented 2 years ago

Seems like git checkout in nodenv_user resource does not update git codebase after first run.

For eg, when HEAD or master is specified, it only checks out the very first time and thereafter never updates it. This can cause issues when you'd like to specify a newer node version than what is known by the nodenv version that was checked out at first run.

For tags, this should be good as it isn't a moving target like a branch or HEAD (remote).

Maybe it should use sync instead of checkout? What are your thoughts?

afaundez commented 2 years ago

I think tags should be encouraged instead of using HEAD or master (or any other branch) to get a particular known state. But in that situation, you also want to upgrade, and the case you mentioned happens anyway. So I'll try to do a spec and define what should happen.