Added feature to automatically refresh package meta if ttl expired.

afbobak / nopar

Node PAckage Registry

http://afbobak.github.io/nopar/

Other

42 stars 13 forks source link

Added feature to automatically refresh package meta if ttl expired. #11

Closed dunse closed 10 years ago

dunse commented 10 years ago

There are no test cases specific to this new feature. Maybe someone with buster knowledge could assist?

afbobak commented 10 years ago

Hi --

What do you need with regards to writing test cases? Any specific issue?

-Andreas

dunse commented 10 years ago

Just not sure how to write the test cases for this new functionality. I haven't used buster before..

kaeff commented 10 years ago

Any chance we could get this feature in? I've found nopar suits us very well in hardening our build environment against registry downtimes, but currently, updating a package requires manually invalidating the updated and all dependant packages.

afbobak commented 10 years ago

Sorry about the quiet time, yes, there's a good chance I'll merge and publish it. I moved to a different continent and am still in the process of settling in (finding a place, waiting for my stuff, etc).

glenjamin commented 10 years ago

I'd be keen on this too - let me know if there's anything I can help with code/testing-wise.

ssafejava commented 10 years ago

:thumbsup: for this - starting to be a real pain every time I update packages. Thanks for this PR!

Tinche commented 10 years ago

Heh I was just about to take a shot at this functionality - good to see someone got there before me. :)

Tinche commented 10 years ago

Reading through the patch, this is the implemented behavior:

if the TTL has expired, instead of just returning the cached metadata, nopar will attempt to refresh the meta data
- if the refresh succeeds - update the on-disk metadata (and thus reset the mtime)
- if the refresh fails - return the cached metadata

I'm thinking it might be better (for the upstream node registry) if the mtime would be reset every time, regardless of whether the update succeeds or fails. If your update fails, you get to wait another TTL period to try again. Seems better than just hammering the upstream registry on every request until it yields something :)

ssafejava commented 10 years ago

@Tinche But what if it fails because of a local outage? It would be nice if it worked again upon the next try.

@afbobak What's holding up this PR? I'm happy to contribute if there is something missing.

Tinche commented 10 years ago

I'm thinking having to wait another TTL isn't a big deal. The failure should be logged, and loudly, in any case. Just a suggestion in any case.

afbobak commented 10 years ago

Finally merged into develop branch c6ca511f054d4a5d16aa79c45c0a1ec627f36288. I also gave all of you commit rights to this repository to prevent things getting held up that long again. Please do development on the develop branch and merge patches into develop as well, master is the production branch. Basically follow https://github.com/nvie/gitflow for the development process.

Cheers

glenjamin commented 10 years ago

Cheers for this, I'll try and give it a go soon.

Is there a roadmap around anywhere or are you pretty happy with the current feature set?

afbobak commented 10 years ago

No roadmap as of yet, I'm just going along as I have time ;-)

I just created a small Wiki page: https://github.com/afbobak/nopar/wiki/Wishlist