search

afbobak / nopar

Node PAckage Registry
http://afbobak.github.io/nopar/
Other
42 stars 13 forks source link

Proxy & publish scoped packages #27

Closed glenjamin closed 9 years ago

glenjamin commented 9 years ago

Added basic support for scoped packages as discussed in #26

Seems to work as far as I can tell, there's an empty package at https://www.npmjs.com/package/@glenjamin/simple-sse you can test with.

Have tested:

Edit: publishing turned out to be not much more, so I've folded into this PR.

glenjamin commented 9 years ago

Publishing works now too, have updated overview to match.

Would appreciate code review rather than just dropping straight into develop :tada:

afbobak commented 9 years ago

Code is understandable, style is accordingly to the existing style and test cases have been added. And you cleaned up some existing code.

Looks good enough to be merged, bumped to 0.7.0 and made available publicly.

glenjamin commented 9 years ago

Good stuff, I'll see about cutting a release this afternoon.

glenjamin commented 9 years ago

I think I got the steps right:

I don't have publish perms on npm, could you add me or publish 0.7.0 please? (same username)