search

afbora / Kirby-Tabs-Field

The tab field type is designed specifically for use within the fields.
77 stars 11 forks source link

Bundle as plugin when Kirby 2.3 is released #10

Closed jenstornell closed 7 years ago

jenstornell commented 8 years ago

2.3 has been released. :)

afbora commented 8 years ago

What can i do for this? :smile:

dweidner commented 8 years ago

One think could be to add a package.json file to allow installing your field via the new Kirby CLI. See the following page for more details: https://github.com/getkirby/cli#kirby-plugininstall

jenstornell commented 8 years ago

https://getkirby.com/docs/developer-guide/plugins/registry

dweidner commented 8 years ago

Well the extension registry would only make sense, if this "plugin" provides more functionality than a panel field, for example providing additional field methods. Users are supposed to install the files into site/fields and not into site/plugins. There is no need to use the extension registry here.

jenstornell commented 8 years ago

I quote one of the crew members:

https://forum.getkirby.com/t/multiselect-field/1213/19

With the new registry in Kirby 2.3, I believe all third-party elements like fields, snippets, blueprints etc. should also be delivered wrapped as a plugin. This enables us to keep only custom elements that are rather specific to the project in site/fields, site/tags etc.

afbora commented 8 years ago

@dweidner @jenstornell Added https://github.com/afbora/Kirby-Tabs-Field/commit/72ce2eebb6480251e12832f2784ee486ee47c5ea

dweidner commented 8 years ago

Thank you for the reference, @jenstornell. I have to disagree though. I would expect fields to be in the site/fields folder regardless of the author of a field/plugin.

afbora commented 8 years ago

Specified as type: kirby-field in package.json

jenstornell commented 8 years ago

It seems like you have @dweidner on your side as he setup the package.json as field. I have not changed my mind about it tho.

dweidner commented 8 years ago

I think we should move the discussion to another issue: https://github.com/distantnative/field-multiselect/issues/18

malvese commented 8 years ago

When I try to install the plugin with Kirby's CLI I get this error: [RuntimeException] Invalid Kirby Plugin Type

afbora commented 7 years ago

@malvese Could you try with downloaded new version?

malvese commented 7 years ago

@afbora Sorry for the delay! I just tried and it now works fine :) Thanks!