search

afbora / kirby-blade

Enable Laravel Blade Template Engine for Kirby 3
MIT License
20 stars 7 forks source link

Option `doMakeSameDomainsLinksRelative` requires array, not boolean #23

Open S1SYPHOS opened 2 years ago

S1SYPHOS commented 2 years ago

Hey there, when looking at voku/htmlmin options, it's clear that doMakeSameDomainsLinksRelative is the only option receiving an array (not a boolean like the others). Therefore, it's logical that passing true / false inside config.php throws a TypeError:

Screenshot from 2022-06-25 10-42-51

I'd suggest passing every option 'as-is', or at least check for $option == 'doMakeSameDomainsLinksRelative' :confused:

Cheers, S1SYPHOS

S1SYPHOS commented 2 years ago

FYI I opened an issue over at voku/htmlmin because I find the naming scheme somewhat inconsistent.