afeinstein20 / eleanor

A tool for light curve extraction from the TESS FFIs.
MIT License
92 stars 39 forks source link

Add keyword to plot false alarm probabilities with vis.pixel_by_pixel periodograms #241

Closed shbhuk closed 2 years ago

shbhuk commented 2 years ago

As discussed in Issue #240, I've added an extra keyword, which defaults to None, but can be set to float values to include dashed horizontal lines signifying the false alarm probabilities from the LS periodogram.

Let me know if there are any questions or concerns.

I wasn't sure if there is an active dev branch to push to and hence defaulted to main. Feel free to modify the target branch.

Shubham

afeinstein20 commented 2 years ago

This looks great @shbhuk ! Super useful upgrade here to the visualization class. I'm going to accept your PR and close the Enhancement Issue :)