search

afeinstein20 / eleanor

A tool for light curve extraction from the TESS FFIs.
MIT License
92 stars 39 forks source link

Provide fix for #243 #244

Closed ethankruse closed 2 years ago

ethankruse commented 2 years ago

The fix of potentially dividing by 0 or a negative median we found in #243.

In theory this will still fail if every cadence is negative, but... well... we'll cross that bridge if we ever get there.

ethankruse commented 2 years ago

Also, every time I was running eleanor using your MAST postcards to test against, I was getting a "could not find pointing model" warning. I think it was a combo of not searching for the MAST hlsp file name format as well as raising the warning when you were just checking if the pointing model exists at all. So I think this fixes those.

benmontet commented 2 years ago

Yep these all look sensible to me, merging in, thanks @ethankruse!