afeinstein20 / stella

For characterizing flares with convolutional neural networks
https://adina.feinste.in/stella
MIT License
26 stars 18 forks source link

Got many more flares than tutorial #12

Closed marioraulhq closed 3 years ago

marioraulhq commented 3 years ago

Hi!

While working through the tutorial, I found that ff.flare_table is giving me many more flares than what the tutorial suggests. At a threshold of 0.5, the tutorial says that there are 16 such flares while I'm getting 31. I got the same result using both the pip and GitHub version. At first I thought I might have made a mistake somewhere, so I decided to run the exact same thing that's shown in https://adina.feinste.in/stella/getting_started/other_features.html- I still got the same thing.

Do you have any suggestions about what I could do to work through this?

Thanks, Mario H.

afeinstein20 commented 3 years ago

Hi Mario,

Sorry for such a delayed response to this issue. Could you please send me what version of tensorflow, numpy, and scipy you are using? This may help me diagnose what is going wrong.

Thanks!!

marioraulhq commented 3 years ago

Hi Adina,

No worries, and I apologize for my equally long reply too. With all the new changes and versions that have came out since I originally made my post, I don't think this ticket is too much of an issue anymore. Besides, I think I got everything to work as intended. Thanks for the reply!