afeinstein20 / stella

For characterizing flares with convolutional neural networks
https://adina.feinste.in/stella
MIT License
26 stars 18 forks source link

DownloadSets not found #20

Open cmurray-astro opened 2 years ago

cmurray-astro commented 2 years ago

Hello! Following your documentation for Creating A New CNN, after pip installing stella (version=0.0.5) I get the following error:

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
/var/folders/04/6pd9ml351599_h45qtqtg_7m0001md/T/ipykernel_64986/407614620.py in <module>
      3 
      4 # download flare catalog
----> 5 download = stella.DownloadSets(fn_dir=data_dir)
      6 download.download_catalog()
      7 # download light curve files

AttributeError: module 'stella' has no attribute 'DownloadSets'

But when I install stella from source it works. Perhaps a version issue with pip?

github-actions[bot] commented 2 years ago

Hi there! This is a test of github actions.

afeinstein20 commented 2 years ago

Hi @cmurray-astro ! The latest version on PyPI (which is consistent with the source code here) is version == 0.1.0. Could you try installing that version and seeing if DownloadSets is there? Thanks!

cmurray-astro commented 2 years ago

Interesting! When I try to pip install version=0.1.0 (via a requirements file in a new environment) I get a conflict between stella and other packages. e.g.,:

ERROR: Cannot install -r requirements.txt (line 3) and -r requirements.txt (line 8) because these package versions have conflicting dependencies.

The conflict is caused by:
    lightkurve 2.1.0 depends on scipy>=1.7; python_version >= "3.8" and python_version < "3.11"
    stella 0.1.0 depends on scipy==1.4.1

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

Is there a reason that stella requires scipy=1.4.1? Also, why does pip install stella collect version 0.0.5?

cmurray-astro commented 2 years ago

will add that it all works when I install from github, e.g.: pip install git+https://github.com/afeinstein20/stella.git

afeinstein20 commented 2 years ago

Ohh okay, I thought I had updated stella to work with the latest lightkurve version, but I can check that out this week and hopefully fix that in the requirements file! Thanks for pointing that out!

mcregogarcia commented 11 months ago

I have this same problem, and it doesn't fix by installing stella from

pip install git+https://github.com/afeinstein20/stella.git

image

cmurray-astro commented 10 months ago

@afeinstein20 pinging you to resurface this issue -- can you update stella to use the latest lightkurve version? The Hello Universe notebook example has long been broken, and I think this would be the easiest way to fix it