afeinstein20 / stella

For characterizing flares with convolutional neural networks
https://adina.feinste.in/stella
MIT License
26 stars 18 forks source link

Peak Index Grouping Issue #28

Open ibiglari opened 11 months ago

ibiglari commented 11 months ago

https://github.com/afeinstein20/stella/blob/f9ffd78d1c7279012e870f3657812595f18eee74/stella/mark_flares.py#L92C1-L92C33

If groups are not of the same size, this line will cause an exception.

Let's say peaks are detected at tpeak=[100, 150, 151, 152, 191, 192].

This function will try to group them into [[100], [150, 151, 152], [191,192]] and then return this as a two dimensional array, instead of array of arrays, leading to a crash.

github-actions[bot] commented 11 months ago

Hi there! This is a test of github actions.