afeld / backbone-nested

A plugin to make Backbone.js keep track of nested attributes - looking for maintainers! https://github.com/afeld/backbone-nested/issues/157

https://afeld.github.com/backbone-nested/

MIT License

443 stars 83 forks source link

test case for issue #60 #117

Open tomhicks opened 10 years ago

tomhicks commented 10 years ago

demonstrates issue where setting a value inside a nested array erroneously triggers an add event, when no item has been added

tomhicks commented 10 years ago

I meant "issue #60" not "PR #60" in the title but I can't edit it - 422 (Unprocessable Entity)

gkatsev commented 10 years ago

So, this PR should create a failing testcase?

tomhicks commented 10 years ago

Yep. I'm having a look at the fix now.

I'm not suggesting this should be merged yet,

gkatsev commented 10 years ago

Yeah, totally, just wanted to make sure I'm understanding it correctly. :smile_cat:

tomhicks commented 10 years ago

60 was raised 2 years ago, yet this is a very popular Backbone extension - what happened?! (Maybe I'll find out it's really hard to fix and that's the reason!)

tomhicks commented 10 years ago

I'm not convinced that this is either the most efficient, or the most robust way of tackling this. Seems to do the job though.

I reckon this is ready to merge if no-one reckons we need more tests around this.

tomhicks commented 10 years ago

Any news on this one?