Closed gdw2 closed 9 years ago
Actually, it should. Backbone-nested installs backbone and grabs its tests via bower, currently.
However, it shouldn't be a peerDependency
. It should be made a devDependency
, actually.
much better! I defer to your wisdom, though, @gkatsev.
I have a feeling that the tests would fail because bower install
wasn't run.
We probably want to change install
script to pretest
which also checks to see whether bower was installed. Maybe something like, in addition to whats there:
{
"scripts": {
"pretest": "if [ ! -d vendor/backbone ]; then bower install;"
}
}
+1 Any news on this?
+1 Can we get this in?
I'm fine with it, as long as we can get tests to pass. Maybe we just take the bower
dependency out completely, and just tell people to install it separately? Need to get tests passing though, so maybe adding a before_install
to .travis.yml
.
I've been meaning to fix this. I believe the solution is to get rid of all peerDependencies
and move them to be devDependencies
. Then I believe we can just run bower install
as part of the test
script.
I agree about moving them into devDependencies. Do you mean moving "bower install" into the grunt script?
We shouldn't have the install
script because otherwise it'll try to install bower when someone installs this package as a dependency. We could have two test scripts but they can't share the same name.
Closed by #136.
Currently, 'npm install backbone-nested' requires bower. It shouldn't.