afeld / backbone-nested

A plugin to make Backbone.js keep track of nested attributes - looking for maintainers! https://github.com/afeld/backbone-nested/issues/157
https://afeld.github.com/backbone-nested/
MIT License
445 stars 83 forks source link

remove bower dependency #122

Closed gdw2 closed 9 years ago

gdw2 commented 10 years ago

Currently, 'npm install backbone-nested' requires bower. It shouldn't.

gkatsev commented 10 years ago

Actually, it should. Backbone-nested installs backbone and grabs its tests via bower, currently.

gkatsev commented 10 years ago

However, it shouldn't be a peerDependency. It should be made a devDependency, actually.

gdw2 commented 10 years ago

much better! I defer to your wisdom, though, @gkatsev.

gkatsev commented 10 years ago

I have a feeling that the tests would fail because bower install wasn't run. We probably want to change install script to pretest which also checks to see whether bower was installed. Maybe something like, in addition to whats there:

{
  "scripts": {
    "pretest": "if [ ! -d vendor/backbone ]; then bower install;"
  }
}
WRidder commented 9 years ago

+1 Any news on this?

kentmw commented 9 years ago

+1 Can we get this in?

afeld commented 9 years ago

I'm fine with it, as long as we can get tests to pass. Maybe we just take the bower dependency out completely, and just tell people to install it separately? Need to get tests passing though, so maybe adding a before_install to .travis.yml.

gkatsev commented 9 years ago

I've been meaning to fix this. I believe the solution is to get rid of all peerDependencies and move them to be devDependencies. Then I believe we can just run bower install as part of the test script.

kentmw commented 9 years ago

I agree about moving them into devDependencies. Do you mean moving "bower install" into the grunt script?

gkatsev commented 9 years ago

We shouldn't have the install script because otherwise it'll try to install bower when someone installs this package as a dependency. We could have two test scripts but they can't share the same name.

afeld commented 9 years ago

Closed by #136.