search

afeld / backbone-nested

A plugin to make Backbone.js keep track of nested attributes - looking for maintainers! https://github.com/afeld/backbone-nested/issues/157
https://afeld.github.com/backbone-nested/
MIT License
443 stars 83 forks source link

install npm modules in `npm test` #137

Closed mendenhallmagic closed 9 years ago

mendenhallmagic commented 9 years ago

I figured we might as well run npm install, which seems to be quick when everything is cached and installed already, along with bower install (which is not so quick).

gkatsev commented 9 years ago

npm install should be a prerequisite. I think the best case scenario is that we should move off of bower and only use npm.

mendenhallmagic commented 9 years ago

ok, no problemo

gkatsev commented 9 years ago

If you can figure that out, that'll be awesome!

mendenhallmagic commented 9 years ago

How hard could it be ;)

I will if I think about it...

I will go ahead and express my appreciation for #136. Now my team isn't dependent on bower (yay!). I had a lingering commit locally, trying to get better at this open-source thing.

mendenhallmagic commented 9 years ago

Closing and submitting new PR using bower-to-npm branch.