Use `_.extend` instead of `$.extend`

afeld / backbone-nested

A plugin to make Backbone.js keep track of nested attributes - looking for maintainers! https://github.com/afeld/backbone-nested/issues/157

https://afeld.github.com/backbone-nested/

MIT License

445 stars 83 forks source link

Use `_.extend` instead of `$.extend` #155

Closed marnen closed 7 years ago

marnen commented 8 years ago

jQuery doesn't load properly outside of a browser environment, so using it in Mocha tests is harder than necessary. Some of this library, however, uses $.extend in critical places, meaning that the jQuery dependency infects even Mocha tests that don't need a browser. I suggest replacing with _.extend or something to make life easier. (I'll make a pull request in the next few days, I hope.)

afeld commented 8 years ago

Works for me! Also, 👋 Marnen!

just-boris commented 8 years ago

Pull request #156

juancarlosfarah commented 8 years ago