search

afeld / backbone-nested

A plugin to make Backbone.js keep track of nested attributes - looking for maintainers! https://github.com/afeld/backbone-nested/issues/157
https://afeld.github.com/backbone-nested/
MIT License
445 stars 83 forks source link

Used JSON.parse(JSON.stringify()) to deepClone objects instead of $.extend #158

Closed pruik closed 7 years ago

pruik commented 7 years ago

This is a concurrent implementation with melissawimberly's pull request, but simplified and will throw an Error in case of a circular dependency.

afeld commented 7 years ago

Very open to this if we can get the tests passing. Thanks!

Closes #155.

pruik commented 7 years ago

That should do it, the devDependency in bower.json was off. I also removed jQuery

afeld commented 7 years ago

Awesome, thanks so much! Also, you now have commit rights 👋

afeld commented 7 years ago

(But please continue to use pull requests for changes.)