search

afeld / backbone-nested

A plugin to make Backbone.js keep track of nested attributes - looking for maintainers! https://github.com/afeld/backbone-nested/issues/157
https://afeld.github.com/backbone-nested/
MIT License
444 stars 83 forks source link

_delayedTrigger miss the options argument #83

Closed zincli closed 11 years ago

zincli commented 11 years ago

function _delayedTrigger miss the options argument from set method, may cause bug with other plugins, such as two-way bindings can't recognize a binding set by set( attr, value, options )

It could be fixed by add opts to the _delayedTrigger like 

_delayedChange: function(attrStr, newVal, options){
      this._delayedTrigger('change:' + attrStr, this, newVal, options);
      ...
}
afeld commented 11 years ago

Good catch, thanks! Want to submit a PR so you get credit for the fix?

zincli commented 11 years ago

@afeld OK, thanks, I will submit a PR later, lots of work to do =. =

afeld commented 11 years ago

Closed by #84