aferodeveloper / AferoSwiftSDK

SDK for creating Swift/iOS-based Afero clients
MIT License
3 stars 1 forks source link

[BUG] Afero Framework Issue #42

Open beni-smoca opened 2 years ago

beni-smoca commented 2 years ago

Describe the bug Compile error in AferoSwiftSDK/Core/AferoSofthub+Utils.swift on Line 367 and 483 in version 1.5.0.

Missing argument for parameter 'setupModeDeviceGoneHandler' in call

The function AferoSofthub.start(...) expects a new parameter setupModeDeviceGoneHandler: which is not used in the function Softhub.start(...).

To Reproduce Steps to reproduce the behavior:

  1. Update AferoSwiftSDK version in Podfile to 1.5.0
  2. Execute pod install
  3. Open .xcworkspace and build it

Expected behavior No compile error in the AferoSwiftSDK.

Development Environment (please complete the following information):

Deployment Environment (please complete the following information)

Workaround Add post install hook to Podfile to ignore the source file.

post_install do |installer|
  installer.pods_project.build_configurations.each do |config|
      config.build_settings["EXCLUDED_SOURCE_FILE_NAMES"] = "**/AferoSwiftSDK/Core/AferoSofthub+Utils.swift"
  end
end

Full Text of Podfile

source 'https://github.com/aferodeveloper/Podspecs.git'
source 'https://github.com/CocoaPods/Specs.git'

platform :ios, '9.3'

use_frameworks!

workspace 'aferolab.xcworkspace'

# MARK: -
# MARK: Prerequisite definitions

XCODE_VERSION = (`xcodebuild -version`.scan /^Xcode\s+(\S+)$/)[0][0]
puts "Using Xcode version: #{XCODE_VERSION}"

def base_pods
    pod 'AferoSwiftSDK', '~> 1.5'
    pod 'AferoSwiftSDK/AFNetworking', '~> 1.5'

    # Pods from original example project.
    # Mostly dependencies already part of AferoSwiftSDK

    #pod 'AFNetworking/NSURLSession', :inhibit_warnings => true
    #pod 'CryptoSwift', '1.4.0'
    #pod 'CocoaLumberjack/Swift', '3.5.2', :inhibit_warnings => true
    #pod 'ReactiveSwift', '5.0.0', :inhibit_warnings => true
    #pod 'PromiseKit/CorePromise', '4.5.1'
    #pod 'HTTPStatusCodes', '~> 3.2'

    pod 'SwiftyBeaver'
end

def test_pods
    pod 'Quick', :inhibit_warnings => true
    pod 'Nimble', :inhibit_warnings => true
    pod 'OHHTTPStubs/Swift'
end

# MARK: - Subprojects -
# MARK: * AferoLab

target 'AferoLab' do

    project 'AferoLab/AferoLab.xcodeproj'

    base_pods

    pod 'LKAlertController', '1.12.2'
    pod 'SVProgressHUD', '~> 2'
    pod 'QRCodeReader.swift', '~> 10'
#    pod 'AferoSofthub', :path => '../../AferoSofthub'

end

target 'AferoLabTests' do
  project 'AferoLab/AferoLab.xcodeproj'
  inherit! :search_paths
end

target 'AferoLabUITests' do
  project 'AferoLab/AferoLab.xcodeproj'
  inherit! :search_paths
end

post_install do |installer|

end

Full Text of Podfile.lock

PODS:
  - AferoSofthub (1.8.2)
  - AferoSwiftSDK (1.5.0):
    - AferoSwiftSDK/Core (= 1.5.0)
  - AferoSwiftSDK/AFNetworking (1.5.0):
    - AferoSwiftSDK/Core
    - AFNetworking/NSURLSession (~> 3.1)
    - AFOAuth2Manager (~> 3.0)
  - AferoSwiftSDK/Core (1.5.0):
    - AferoSofthub (~> 1.8)
    - CocoaLumberjack/Swift (~> 3.7.4)
    - CocoaZ (~> 1.4)
    - CryptoSwift (= 1.5.1)
    - HTTPStatusCodes (~> 3.2)
    - PromiseKit/CorePromise (~> 4.5)
    - ReactiveSwift (~> 7.0)
    - RSEnvironment (= 0.0.3)
  - AFNetworking/NSURLSession (3.2.1):
    - AFNetworking/Reachability
    - AFNetworking/Security
    - AFNetworking/Serialization
  - AFNetworking/Reachability (3.2.1)
  - AFNetworking/Security (3.2.1)
  - AFNetworking/Serialization (3.2.1)
  - AFOAuth2Manager (3.0.0):
    - AFNetworking/NSURLSession (~> 3.0)
  - CocoaLumberjack/Core (3.7.4)
  - CocoaLumberjack/Swift (3.7.4):
    - CocoaLumberjack/Core
  - CocoaZ (1.4.2)
  - CryptoSwift (1.5.1)
  - HTTPStatusCodes (3.3.1)
  - LKAlertController (1.12.2)
  - PromiseKit/CorePromise (4.5.2)
  - QRCodeReader.swift (10.1.0)
  - ReactiveSwift (7.0.0)
  - RSEnvironment (0.0.3)
  - SVProgressHUD (2.2.5)
  - SwiftyBeaver (1.9.5)

DEPENDENCIES:
  - AferoSwiftSDK (~> 1.5)
  - AferoSwiftSDK/AFNetworking (~> 1.5)
  - LKAlertController (= 1.12.2)
  - QRCodeReader.swift (~> 10)
  - SVProgressHUD (~> 2)
  - SwiftyBeaver

SPEC REPOS:
  https://github.com/aferodeveloper/Podspecs.git:
    - AferoSofthub
    - AferoSwiftSDK
  https://github.com/CocoaPods/Specs.git:
    - AFNetworking
    - AFOAuth2Manager
    - CocoaLumberjack
    - CocoaZ
    - CryptoSwift
    - HTTPStatusCodes
    - LKAlertController
    - PromiseKit
    - QRCodeReader.swift
    - ReactiveSwift
    - RSEnvironment
    - SVProgressHUD
    - SwiftyBeaver

SPEC CHECKSUMS:
  AferoSofthub: 45d2644360915010878394d0d28873418dfad3f6
  AferoSwiftSDK: 390fa335fe1a159c4779af72dbfaafb3432ac2c5
  AFNetworking: b6f891fdfaed196b46c7a83cf209e09697b94057
  AFOAuth2Manager: 0566da1be64883e339813d411229fdc9a84dab7c
  CocoaLumberjack: 543c79c114dadc3b1aba95641d8738b06b05b646
  CocoaZ: a296b1fbea2c648daf2ccabb5403ed354569e633
  CryptoSwift: c4f2debceb38bf44c80659afe009f71e23e4a082
  HTTPStatusCodes: a07dff597042a9f692cf4f979cb0fd91fc938835
  LKAlertController: 10c7e8627e5d4757d03b4f53469f35ded14c378f
  PromiseKit: 743e497a5f505a470d3bbbf4ce0663c1268af0a4
  QRCodeReader.swift: 373a389fe9a22d513c879a32a6f647c58f4ef572
  ReactiveSwift: 48c4b9d3b497e8dd20b10300bb1a28ff93550f13
  RSEnvironment: 653f92019569ef8fb5005d4bb34cd1ccaf50727f
  SVProgressHUD: 1428aafac632c1f86f62aa4243ec12008d7a51d6
  SwiftyBeaver: 84069991dd5dca07d7069100985badaca7f0ce82

PODFILE CHECKSUM: 1a98d9ba6dec09fe03af3502da94901365a8bafd

COCOAPODS: 1.11.3
marnberg commented 2 years ago

Please use: pod 'AferoSofthub', '1.8.0' until AferoSwiftSDK support new features in AferoSofthub 1.8.2. No new bug fixes in that version. It should have really been versioned 1.9.0 instead.