search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
315 stars 36 forks source link

Slow noise reduction #112

Open assaft opened 8 years ago

assaft commented 8 years ago

Hello, I'm running PhotoFlow 0.2.7 on Windows 10, and it looks great but it seems that the noise reduction filter makes the export operation very long - about 124 seconds - instead of 3 seconds when the layer is disabled. Is this a known problem? My source is a RAW file from an Olympus camera (ORF file). The PFI file is attached, I disabled everything but the NR to make it easier to reproduce the problem. Thanks! PA030720.zip

aferrero2707 commented 8 years ago

Hi!

The noise reduction tool still needs optimisations... it is derived from Darktable, and requires a conversion from RGB to Lab and back to RGB in addition to the NR processing itself.

I am planning to work on a RGB version for next release, which will hopefully make the processing faster, at least as fast as in the Darktable case. I also need to introduce some optimisation of the RGB <-> Lab conversions, that are used in various places in the PhF code...

assaft commented 8 years ago

Thanks! just an idea - I know that the UI of RawTherapee allows the user to apply NR in RGB, so maybe this algorithm avoids the need to convert to LAB. But I don't know the internals, and I also don't know what is preferable for more effective NR.