search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
309 stars 36 forks source link

Gaussian Blur => Endless caching #114

Open assaft opened 7 years ago

assaft commented 7 years ago

Photoflow 0.2.7 (patched as described in Issue #113 ) on Windows 10.

Once I added a gaussian blur layer, Photoflow got into an endless loop of caching (and high CPU usage). To reproduce turn on/off the gaussian blur layer.

Files: RAW PFI

assaft commented 7 years ago

Did you manage to reproduce this problem?

aferrero2707 commented 7 years ago

Could you try with the latest package available here? I updated the packages this morning, and works for me on your PFI file.

Thanks!

assaft commented 7 years ago

I just tried it - the latest package crashes when I open the PFI (while showing "updating"). Besides, it looks like it doesn't have recent UI changes the you mentioned here. So maybe the Windows package is not up to date?

aferrero2707 commented 7 years ago

Are you sure you have taken photoflow-20161120-setup.zip or photoflow-20161120.zip?

aferrero2707 commented 7 years ago

Here is a screenshot of the 20161120 version running under wine on my PC:

screen shot 2016-11-20 at 13 25 20
assaft commented 7 years ago

My bad - I must have used the package of the 19th. No crash on the latest build. However, the 'caching' is still going on forever when I enable the Gaussian Blur layer.

aferrero2707 commented 7 years ago

I've added caching for the noise reduction layer, which should speed things up... applying a large gaussian blur on top of a non-cached denoising seems to be too much from the processing point of view, due to the large amount of tile re-processing needed by the large blur radius.

Could you try with the photoflow-20161121*.zip packages?

assaft commented 7 years ago

Problem solved. However, now the issue of slow NR is more apparent during development (and not just during export) - it took Photoflow about 112 seconds to complete caching when the NR layer is enabled.