search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
319 stars 36 forks source link

Unexpected color shifts when wavelet residual layer is disabled #115

Closed assaft closed 8 years ago

assaft commented 8 years ago

Photoflow 0.2.7 (patched as described in Issue #113) on Windows 10.

I played with the new wavelet decomposition preset and applied it to my development. Once I disabled the residual layer I got this: wavelet

ORF file PFI file

aferrero2707 commented 8 years ago

This is normal: the residual layer (the one associated with the "split details" tool) is actually outputting several images at once, one for the residual + one for each detail level. The clone layers inside the "scale 1/2/3/45" groups simply clone one of the output images of the "split details" layer, which is then blended back in "grain merge" mode.

If you hide the "split details" layer, you also disable the input of the clone layers in the "scale 1/2/3/45" groups, with unpredictable results.

In order to use the various detail levels for image sharpening, what you need to do is to add a clone of the original image just above the "split details" layer: this way, the various "grain merge" blends will be applied to the original image and not the residual one.

aferrero2707 commented 8 years ago

Fixed by commit https://github.com/aferrero2707/PhotoFlow/commit/0641fb091fbe42e2a119166e5365f0088849ae48 in stable branch, which adds the possibility of outputting the original image instead of the wavelets residual in the "split details" tool.