aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
315 stars 36 forks source link

strict-aliasing-punning #122

Open awissu opened 8 years ago

awissu commented 8 years ago

Hi! I bumped into rpmlint errors, when tried to build rpm in OBS:

[  945s] I: Program is likely to break with new gcc. Try -fno-strict-aliasing.
[  945s] W: photoflow strict-aliasing-punning /home/abuild/rpmbuild/BUILD/PhotoFlow-0.2.7/src/external/rawspeed/RawSpeed/BitPumpJPEG.h:53, 88, 126
[  945s] W: photoflow strict-aliasing-punning /home/abuild/rpmbuild/BUILD/PhotoFlow-0.2.7/src/external/rawspeed/RawSpeed/BitPumpMSB.h:53, 88, 126
[  945s] W: photoflow strict-aliasing-punning /home/abuild/rpmbuild/BUILD/PhotoFlow-0.2.7/src/external/rawspeed/RawSpeed/MosDecoder.cpp:110
[  945s] W: photoflow strict-aliasing-punning /home/abuild/rpmbuild/BUILD/PhotoFlow-0.2.7/src/rt/rtengine/sleef.c:1216, 1217, 1223, 1224, 1230, 1231
[  945s] 
[  945s] I: Program returns random data in a function
[  945s] E: photoflow no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/PhotoFlow-0.2.7/src/operations/subtr_image.hh:59, 77
[  945s] 
[  945s] I: Program returns random data in a function
[  945s] E: photoflow no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/PhotoFlow-0.2.7/src/operations/subtr_image.hh:59, 77

See: https://build.opensuse.org/package/live_build_log/home:awissu:branches:graphics/photoflow/openSUSE_Tumbleweed/x86_64

aferrero2707 commented 8 years ago

I fixed the missing return value error in master branch. For the "strict-aliasing-punning" issue, I need to see how to optimally change the compiler options to add "-fno-strict-aliasing" only where needed.

awissu commented 8 years ago

I fixed the missing return value error in master branch.

[ 1042s] I: Program returns random data in a function
[ 1042s] E: photoflow no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/PhotoFlow-0.2.7/src/operations/subtr_image.hh:59

For the "strict-aliasing-punning" issue, I need to see how to optimally change the compiler options to add "-fno-strict-aliasing" only where needed.

See: https://build.opensuse.org/package/live_build_log/home:awissu:branches:graphics/photoflow/openSUSE_13.2/i586