extended character issue - windows 10 - photoflow 0.2.8

[phweyland]

When there are some accentueted characters, they are not understood and PF crashes.

[aferrero2707]

Thanks for reporting! I will look into that as soon as I am back to work.

[phweyland]

Just checked the issue is still opened: PF freezes and I get this on the cmd window:

PF::Image::do_update(): updating pipeline #0
ImageReaderPar::build(): creating new RawImage for file D:\Documents\Images\Photos\2010\2017\20170605_CahuzA"res\20170605_CahuzA"res_017.NEF
PreviewScrolledWindow::on_map() called.
RawImage::RawImage(): file "D:\Documents\Images\Photos\2010\2017\20170605_CahuzA"res\20170605_CahuzA"res_017.NEF" not found
                      trying with "20170605_CahuzA"res_017.NEF"
RawImage::RawImage(): "20170605_CahuzA"res_017.NEF" not found

[phweyland]

Hi, on the last window build the error is still there. No hope to fix that ? Thanks Philippe

[aferrero2707]

I still cannot reproduce this problem on non-Windows systems, so I have to proceed a bit blindly until I get my hands on a Windows machine. However I have some suspicion, and I will double check how the file names are transferred from the GTK file dialog to the application...

Sorry for taking so long, but the Windows-specific bugs are always more painful to investigate.

[phweyland]

I understand. I've learned to build dt on windows (thanks to the windows build.txt document). If that could help I can try to build pf as well. If I succeed I could make some tests under your direction...

[aferrero2707]

I have finally managed to prepare a new Windows package, with an hopefully better handling of the non-ASCII characters in input file names. If this will still not work, it should at least provide better diagnostic messages in the terminal, so please provide the full terminal output in case the problem persists...

Here is the direct link: https://github.com/aferrero2707/PhotoFlow/releases/download/continuous/photoflow-w64-20181128_1001-git-stable-b38ea17d572c98568af178754945a66ed4d874af.zip

[phweyland]

Thanks for the update. The image doesn't open and the terminal content is the following.

[] (photoflow.exe:11392): GLib-GIO-CRITICAL : 18:03:15.451: g_content_type_is_a: assertion 'type != NULL' failed (photoflow.exe:11392): GLib-GIO-CRITICAL : 18:03:15.453: g_content_type_is_a: assertion 'type != NULL' failed (photoflow.exe:11392): GLib-GIO-CRITICAL **: 18:03:15.456: g_content_type_is_a: assertion 'type != NULL' failed MainWindow::on_button_open_clicked: new last_dir="D:\Documents\Images\Photos\2010\2018\20181104_Midi" MainWindow::on_button_open_clicked: ufilename="D:\Documents\Images\Photos\2010\2018\20181104_Midi\20181111_Corrèze_051.NEF" MainWindow::on_button_open_clicked: filename="D:\Documents\Images\Photos\2010\2018\20181104_Midi\20181111_Corrèze_051.NEF" MainWindow::open_image: filename="D:\Documents\Images\Photos\2010\2018\20181104_Midi\20181111_Corrèze_051.NEF" MainWindow::open_image: basename="20181111_Corrèze_051.NEF" ImageEditor::on_realize() called. ImageEditor::open_image(): opening image D:\Documents\Images\Photos\2010\2018\20181104_Midi\20181111_Corrèze_051.NEF ... ImageEditor::open_image(): opening image file D:\Documents\Images\Photos\2010\2018\20181104_Midi\20181111_Corrèze_051.NEF ... Opening RAW image D:\Documents\Images\Photos\2010\2018\20181104_Midi\20181111_Corrèze_051.NEF LFDbHelper::LFDbHelper() called RawLoaderPar::build(): creating new RawImage for file D:\Documents\Images\Photos\2010\2018\20181104_Midi\20181111_Corrèze_051.NEF PreviewScrolledWindow::on_map() called. RawImage::RawImage(): file "D:\Documents\Images\Photos\2010\2018\20181104_Midi\20181111_Corrèze_051.NEF" not found trying with "20181111_Corrèze_051.NEF" RawImage::RawImage(): "20181111_Corrèze_051.NEF" not found LayerManager::rebuild_chain(): missing input data for layer "RAW developer" ImageSizeUpdater::update(): error: NULL image ImageInfo::update(): error: NULL image LayerManager::rebuild_chain(): missing input data for layer "RAW developer" ImageArea::update(): error: NULL image LayerManager::rebuild_chain(): missing input data for layer "RAW developer" Histogram::update(): error: NULL image

[aferrero2707]

@phweyland I just want to let you know that I am working on this issue, and I did at least some progress. Unfortunately there is not much you can do to help me, unless you have a clear idea of how to translate a Glib::ustring into a std::string so that it is correctly read by rawspeed::FileReader...

[phweyland]

Thanks a lot for looking at this. Unfortunately I haven't any idea (even not clear) about the way to make this translation. dt uses also rawspeed FileReader (like in dt_imageio_open_rawspeed) ...

[aferrero2707]

@phweyland I have finally made some progress on this issue. The latest Win64 version should be able to correctly open RAW files with non-ASCII characters. However, saving the work has a .pfi file still results in a corrupted file.

While I improve the situation, could you try to see if opening non-standard RAW files works for you as well?

Thanks!

[phweyland]

Yes ! I can open a file extended ascii characters in filename (in path as well). And yes, the save filename is not correct (as the filename on PF image tab title). BTW, the infinite message on console when browsing has gone (making the browsing a pleasure :-) ) Thanks so much !